generalize_eqs_vars fix incorrect selection of variables to generalize#22001
Merged
Conversation
Dependent equality is not always used by this function so this restriction is too strong. Even if it was needed we should check the register not the library.
SkySkimmer
added
the
request: full CI
coqbot-app
Bot
removed
the
request: full CI
Contributor
Author
|
probably going to need overlay for kami |
SkySkimmer
added
needs: changelog entry
SkySkimmer
added
request: full CI
coqbot-app
Bot
removed
the
request: full CI
SkySkimmer
added
the
needs: overlay
samuelgruetter
pushed a commit
to mit-plv/kami
that referenced
this pull request
May 4, 2026
…eralizations) In Decomposition.v it still wants to generalize `imp` which needs to generalize `substepRuleMap` which causes trouble so I just gave it the explicit list of generalizations to do. Should be backwards compatible.
samuelgruetter
added a commit
to mit-plv/kami
that referenced
this pull request
May 4, 2026
Adapt to rocq-prover/rocq#22001 (dependent induction less useless generalizations)
SkySkimmer
added
request: full CI
coqbot-app
Bot
removed
the
request: full CI
YaZko
pushed a commit
to DeepSpec/InteractionTrees
that referenced
this pull request
May 7, 2026
…endent induction)
YaZko
added a commit
to DeepSpec/InteractionTrees
that referenced
this pull request
May 7, 2026
Adapt to rocq-prover/rocq#22001 (less agressive generalization in dependent induction)
Contributor
Author
|
all overlays merged |
mattam82
approved these changes
May 18, 2026
mattam82
left a comment
mattam82
left a comment
Member
There was a problem hiding this comment.
Checked with @SkySkimmer, LGTM
ppedrot
approved these changes
May 19, 2026
Member
|
@coqbot merge now |
Contributor
|
@ppedrot: Please take care of the following overlays:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #22000
Overlays: